add groupby templated make_min_aggregation factory

rapidsai · Aug 27, 2021 · 4d43263 · 4d43263
1 parent 5bd4321
commit 4d43263
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 6 deletions.
diff --git a/cpp/tests/groupby/max_tests.cpp b/cpp/tests/groupby/max_tests.cpp
@@ -238,9 +238,17 @@ TEST_F(groupby_dictionary_max_test, fixed_width)
   fixed_width_column_wrapper<V>  expect_vals_w({ 0xABC, 0xFFF, 0xF1 });
   // clang-format on
 
-  test_single_agg(keys, vals, expect_keys, expect_vals_w, cudf::make_max_aggregation());
-  test_single_agg(
-    keys, vals, expect_keys, expect_vals_w, cudf::make_max_aggregation(), force_use_sort_impl::YES);
+  test_single_agg(keys,
+                  vals,
+                  expect_keys,
+                  expect_vals_w,
+                  cudf::make_max_aggregation<cudf::groupby_aggregation>());
+  test_single_agg(keys,
+                  vals,
+                  expect_keys,
+                  expect_vals_w,
+                  cudf::make_max_aggregation<cudf::groupby_aggregation>(),
+                  force_use_sort_impl::YES);
 }
 
 template <typename T>

diff --git a/cpp/tests/groupby/min_tests.cpp b/cpp/tests/groupby/min_tests.cpp
@@ -238,9 +238,17 @@ TEST_F(groupby_dictionary_min_test, fixed_width)
   fixed_width_column_wrapper<V>  expect_vals_w({ 0xAAA, 0xBAA, 0x01 });
   // clang-format on
 
-  test_single_agg(keys, vals, expect_keys, expect_vals_w, cudf::make_min_aggregation());
-  test_single_agg(
-    keys, vals, expect_keys, expect_vals_w, cudf::make_min_aggregation(), force_use_sort_impl::YES);
+  test_single_agg(keys,
+                  vals,
+                  expect_keys,
+                  expect_vals_w,
+                  cudf::make_min_aggregation<cudf::groupby_aggregation>());
+  test_single_agg(keys,
+                  vals,
+                  expect_keys,
+                  expect_vals_w,
+                  cudf::make_min_aggregation<cudf::groupby_aggregation>(),
+                  force_use_sort_impl::YES);
 }
 
 template <typename T>