Skip to content

Commit

Permalink
xfail failing pytest in pandas 1.2.3 (#7507)
Browse files Browse the repository at this point in the history
Looks like a new patch to the version of `1.2` was released(`1.2.3`) and this breaks one of our pytest. xfailing that pytest for `1.2.3`.

Authors:
  - GALI PREM SAGAR (@galipremsagar)

Approvers:
  - Christopher Harris (@cwharris)
  - AJ Schmidt (@ajschmidt8)
  - Keith Kraus (@kkraus14)

URL: #7507
  • Loading branch information
galipremsagar authored Mar 3, 2021
1 parent c69b6f8 commit 4d0c160
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions python/cudf/cudf/core/_compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
PANDAS_GE_100 = PANDAS_VERSION >= version.parse("1.0")
PANDAS_GE_110 = PANDAS_VERSION >= version.parse("1.1")
PANDAS_GE_120 = PANDAS_VERSION >= version.parse("1.2")
PANDAS_EQ_123 = PANDAS_VERSION == version.parse("1.2.3")
7 changes: 3 additions & 4 deletions python/cudf/cudf/tests/test_setitem.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pytest

import cudf
from cudf.core._compat import PANDAS_GE_120
from cudf.core._compat import PANDAS_EQ_123, PANDAS_GE_120
from cudf.tests.utils import assert_eq, assert_exceptions_equal


Expand All @@ -21,9 +21,8 @@ def test_dataframe_setitem_bool_mask_scaler(df, arg, value):


@pytest.mark.xfail(
condition=not PANDAS_GE_120,
reason="pandas incorrectly adds nulls with dataframes "
"but works fine with scalars",
condition=PANDAS_EQ_123 or not PANDAS_GE_120,
reason="https://github.com/pandas-dev/pandas/issues/40204",
)
def test_dataframe_setitem_scaler_bool():
df = pd.DataFrame({"a": [1, 2, 3]})
Expand Down

0 comments on commit 4d0c160

Please sign in to comment.