Skip to content

Commit

Permalink
Remove cruft in map_lookup (#11221)
Browse files Browse the repository at this point in the history
This commit removes unused code in `map_lookup.cu` and `map_lookup.hpp`.
#10380 replaced the functionality provided in `map_lookup.*`, and expanded
map-lookup support to all value types, and string/integral key types.
The old map_lookup kernels were retained "just in case".

Removing the old kernels should reduce confusion, and avoid clutter.

Authors:
  - MithunR (https://github.com/mythrocks)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Robert (Bobby) Evans (https://github.com/revans2)

URL: #11221
  • Loading branch information
mythrocks authored Jul 8, 2022
1 parent 148101a commit 4b70c37
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 301 deletions.
1 change: 0 additions & 1 deletion java/src/main/native/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ add_library(
src/ScalarJni.cpp
src/TableJni.cpp
src/aggregation128_utils.cu
src/map_lookup.cu
src/maps_column_view.cu
src/row_conversion.cu
src/check_nvcomp_output_sizes.cu
Expand Down
1 change: 0 additions & 1 deletion java/src/main/native/src/ColumnViewJni.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
#include "cudf_jni_apis.hpp"
#include "dtype_utils.hpp"
#include "jni_utils.hpp"
#include "map_lookup.hpp"
#include "maps_column_view.hpp"

using cudf::jni::ptr_as_jlong;
Expand Down
211 changes: 0 additions & 211 deletions java/src/main/native/src/map_lookup.cu

This file was deleted.

88 changes: 0 additions & 88 deletions java/src/main/native/src/map_lookup.hpp

This file was deleted.

0 comments on commit 4b70c37

Please sign in to comment.