Skip to content

Commit

Permalink
Fix typo in the name of cudf-testing-targets.cmake (#9190)
Browse files Browse the repository at this point in the history
This fix enables local source builds using the build directory as `cudf_ROOT` to find `cudf::cudftestutil` targets again.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)

URL: #9190
  • Loading branch information
trxcllnt authored Sep 8, 2021
1 parent 665c07e commit 42a70f3
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ rapids_export(BUILD cudf
FINAL_CODE_BLOCK build_code_string)

export(EXPORT cudf-testing-exports
FILE ${CUDF_BINARY_DIR}/cudf-testing.cmake
FILE ${CUDF_BINARY_DIR}/cudf-testing-targets.cmake
NAMESPACE cudf::)
rapids_export_write_dependencies(BUILD cudf-testing-exports
"${CUDF_BINARY_DIR}/cudf-testing-dependencies.cmake")
Expand Down
56 changes: 28 additions & 28 deletions cpp/cmake/thirdparty/get_arrow.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -101,34 +101,6 @@ function(find_and_configure_arrow VERSION BUILD_STATIC ENABLE_S3 ENABLE_ORC ENAB
"ARROW_PROTOBUF_USE_SHARED ${ARROW_BUILD_SHARED}"
"ARROW_ZSTD_USE_SHARED ${ARROW_BUILD_SHARED}")

if(Arrow_ADDED)
rapids_export(BUILD Arrow
VERSION ${VERSION}
EXPORT_SET arrow_targets
GLOBAL_TARGETS arrow_shared arrow_static
NAMESPACE cudf::)

rapids_export(BUILD ArrowCUDA
VERSION ${VERSION}
EXPORT_SET arrow_cuda_targets
GLOBAL_TARGETS arrow_cuda_shared arrow_cuda_static
NAMESPACE cudf::)
endif()
# We generate the arrow-config and arrowcuda-config files
# when we built arrow locally, so always do `find_dependency`
rapids_export_package(BUILD Arrow cudf-exports)
rapids_export_package(INSTALL Arrow cudf-exports)

# We have to generate the find_dependency(ArrowCUDA) ourselves
# since we need to specify ArrowCUDA_DIR to be where Arrow
# was found, since Arrow packages ArrowCUDA.config in a non-standard
# location
rapids_export_package(BUILD ArrowCUDA cudf-exports)

include("${rapids-cmake-dir}/export/find_package_root.cmake")
rapids_export_find_package_root(BUILD Arrow [=[${CMAKE_CURRENT_LIST_DIR}]=] cudf-exports)
rapids_export_find_package_root(BUILD ArrowCUDA [=[${CMAKE_CURRENT_LIST_DIR}]=] cudf-exports)

set(ARROW_FOUND TRUE)
set(ARROW_LIBRARIES "")

Expand Down Expand Up @@ -184,6 +156,34 @@ function(find_and_configure_arrow VERSION BUILD_STATIC ENABLE_S3 ENABLE_ORC ENAB
message(FATAL_ERROR "CUDF: Arrow library not found or downloaded.")
endif()

if(Arrow_ADDED)
rapids_export(BUILD Arrow
VERSION ${VERSION}
EXPORT_SET arrow_targets
GLOBAL_TARGETS arrow_shared arrow_static
NAMESPACE cudf::)

rapids_export(BUILD ArrowCUDA
VERSION ${VERSION}
EXPORT_SET arrow_cuda_targets
GLOBAL_TARGETS arrow_cuda_shared arrow_cuda_static
NAMESPACE cudf::)
endif()
# We generate the arrow-config and arrowcuda-config files
# when we built arrow locally, so always do `find_dependency`
rapids_export_package(BUILD Arrow cudf-exports)
rapids_export_package(INSTALL Arrow cudf-exports)

# We have to generate the find_dependency(ArrowCUDA) ourselves
# since we need to specify ArrowCUDA_DIR to be where Arrow
# was found, since Arrow packages ArrowCUDA.config in a non-standard
# location
rapids_export_package(BUILD ArrowCUDA cudf-exports)

include("${rapids-cmake-dir}/export/find_package_root.cmake")
rapids_export_find_package_root(BUILD Arrow [=[${CMAKE_CURRENT_LIST_DIR}]=] cudf-exports)
rapids_export_find_package_root(BUILD ArrowCUDA [=[${CMAKE_CURRENT_LIST_DIR}]=] cudf-exports)

set(ARROW_FOUND "${ARROW_FOUND}" PARENT_SCOPE)
set(ARROW_LIBRARIES "${ARROW_LIBRARIES}" PARENT_SCOPE)

Expand Down

0 comments on commit 42a70f3

Please sign in to comment.