Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix memcheck error in groupby-tdigest get_scalar_minmax (#9339)
The groupby tdigest logic in the `get_scalar_minmax` would access incorrect device memory when encountering an empty group. The index value calculated for a column element in an empty group would be off by -1. This was found running a cuda-memcheck (compute-sanitizer) with the `AllNulls` gtest. Here the first group is empty resulting an out-of-bounds read at `col.element<T>(-1)`. This PR adds a check for the empty group (`valid_count==0`) to prevent reading the incorrect column row. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - https://github.com/nvdbaranec - MithunR (https://github.com/mythrocks) URL: #9339
- Loading branch information