address reviews

rapidsai · May 23, 2022 · 3b152c5 · 3b152c5
1 parent 0a88bda
commit 3b152c5
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 17 deletions.
diff --git a/python/cudf/cudf/io/avro.py b/python/cudf/cudf/io/avro.py
@@ -24,7 +24,7 @@ def read_avro(
             "`read_avro` does not yet support reading multiple files"
         )
 
-    filepath_or_buffer, compression = ioutils.get_reader_filepath_or_buffer(
+    filepath_or_buffer, compression = ioutils.get_reader_path_or_buf(
         path_or_data=filepath_or_buffer, compression=None, **kwargs
     )
     if compression is not None:

diff --git a/python/cudf/cudf/io/csv.py b/python/cudf/cudf/io/csv.py
@@ -60,7 +60,7 @@ def read_csv(
             "`read_csv` does not yet support reading multiple files"
         )
 
-    filepath_or_buffer, compression = ioutils.get_reader_filepath_or_buffer(
+    filepath_or_buffer, compression = ioutils.get_reader_path_or_buf(
         path_or_data=filepath_or_buffer,
         compression=compression,
         iotypes=(BytesIO, StringIO, NativeFile),
@@ -146,7 +146,7 @@ def to_csv(
         path_or_buf = StringIO()
         return_as_string = True
 
-    path_or_buf = ioutils.get_writer_filepath_or_buffer(
+    path_or_buf = ioutils.get_writer_path_or_buf(
         path_or_data=path_or_buf, mode="w", **kwargs
     )
 

diff --git a/python/cudf/cudf/io/json.py b/python/cudf/cudf/io/json.py
@@ -42,7 +42,7 @@ def read_json(
                 source = ioutils.stringify_pathlike(source)
                 source = fs.sep.join([source, "*.json"])
 
-            tmp_source, compression = ioutils.get_reader_filepath_or_buffer(
+            tmp_source, compression = ioutils.get_reader_path_or_buf(
                 path_or_data=source,
                 compression=compression,
                 iotypes=(BytesIO, StringIO),
@@ -74,7 +74,7 @@ def read_json(
                 "multiple files via pandas"
             )
 
-        path_or_buf, compression = ioutils.get_reader_filepath_or_buffer(
+        path_or_buf, compression = ioutils.get_reader_path_or_buf(
             path_or_data=path_or_buf,
             compression=compression,
             iotypes=(BytesIO, StringIO),

diff --git a/python/cudf/cudf/io/orc.py b/python/cudf/cudf/io/orc.py
@@ -171,10 +171,7 @@ def read_orc_statistics(
     files_statistics = []
     stripes_statistics = []
     for source in filepaths_or_buffers:
-        (
-            filepath_or_buffer,
-            compression,
-        ) = ioutils.get_reader_filepath_or_buffer(
+        (filepath_or_buffer, compression,) = ioutils.get_reader_path_or_buf(
             path_or_data=source, compression=None, **kwargs
         )
         if compression is not None:
@@ -326,7 +323,7 @@ def read_orc(
             source = stringify_path(source)
             source = fs.sep.join([source, "*.orc"])
 
-        tmp_source, compression = ioutils.get_reader_filepath_or_buffer(
+        tmp_source, compression = ioutils.get_reader_path_or_buf(
             path_or_data=source,
             compression=None,
             use_python_file_object=use_python_file_object,
@@ -425,7 +422,7 @@ def to_orc(
             "Categorical columns."
         )
 
-    path_or_buf = ioutils.get_writer_filepath_or_buffer(
+    path_or_buf = ioutils.get_writer_path_or_buf(
         path_or_data=fname, mode="wb", **kwargs
     )
     if ioutils.is_fsspec_open_file(path_or_buf):

diff --git a/python/cudf/cudf/io/parquet.py b/python/cudf/cudf/io/parquet.py
@@ -71,7 +71,7 @@ def _write_parquet(
             ValueError("paths must be list-like when partitions_info provided")
 
     paths_or_bufs = [
-        ioutils.get_writer_filepath_or_buffer(path, mode="wb", **kwargs)
+        ioutils.get_writer_path_or_buf(path, mode="wb", **kwargs)
         for path in paths
     ]
     common_args = {
@@ -435,7 +435,7 @@ def read_parquet(
             fs=fs,
         )
     for i, source in enumerate(filepath_or_buffer):
-        tmp_source, compression = ioutils.get_reader_filepath_or_buffer(
+        tmp_source, compression = ioutils.get_reader_path_or_buf(
             path_or_data=source,
             compression=None,
             fs=fs,

diff --git a/python/cudf/cudf/io/text.py b/python/cudf/cudf/io/text.py
@@ -18,7 +18,7 @@ def read_text(
 ):
     """{docstring}"""
 
-    filepath_or_buffer, compression = ioutils.get_reader_filepath_or_buffer(
+    filepath_or_buffer, compression = ioutils.get_reader_path_or_buf(
         path_or_data=filepath_or_buffer,
         compression=None,
         iotypes=(BytesIO, StringIO),

diff --git a/python/cudf/cudf/utils/ioutils.py b/python/cudf/cudf/utils/ioutils.py
@@ -1319,7 +1319,7 @@ def _open_remote_files(
     ]
 
 
-def get_reader_filepath_or_buffer(
+def get_reader_path_or_buf(
     path_or_data,
     compression,
     mode="rb",
@@ -1328,7 +1328,7 @@ def get_reader_filepath_or_buffer(
     byte_ranges=None,
     use_python_file_object=False,
     open_file_options=None,
-    is_raw_text_like_input=False,
+    allow_raw_text_input=False,
     **kwargs,
 ):
     """Return either a filepath string to data, or a memory buffer of data.
@@ -1390,6 +1390,10 @@ def get_reader_filepath_or_buffer(
                     )
 
         else:
+            if len(paths):
+                raise FileNotFoundError(
+                    f"{path_or_data} could not be resolved to any files"
+                )
             if use_python_file_object:
                 path_or_data = _open_remote_files(
                     paths,
@@ -1424,7 +1428,7 @@ def get_reader_filepath_or_buffer(
     return path_or_data, compression
 
 
-def get_writer_filepath_or_buffer(path_or_data, mode, **kwargs):
+def get_writer_path_or_buf(path_or_data, mode, **kwargs):
     """
     Return either a filepath string to data,
     or a open file object to the output filesystem