Inline device_uvector definitions

rapidsai · Jun 13, 2024 · 3961bb4 · 3961bb4
1 parent 14a9294
commit 3961bb4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 41 deletions.
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
@@ -662,7 +662,6 @@ add_library(
   src/unary/nan_ops.cu
   src/unary/null_ops.cu
   src/utilities/default_stream.cpp
-  src/utilities/device_uvector.cpp
   src/utilities/linked_column.cpp
   src/utilities/logger.cpp
   src/utilities/pinned_memory.cpp

diff --git a/cpp/include/cudf/utilities/device_uvector.hpp b/cpp/include/cudf/utilities/device_uvector.hpp
@@ -33,7 +33,16 @@ class device_uvector : public rmm::device_uvector<T> {
    *
    * @return A pointer to the underlying device memory.
    */
-  [[nodiscard]] typename rmm::device_uvector<T>::pointer data() noexcept;
+  [[nodiscard]] typename rmm::device_uvector<T>::pointer data() noexcept
+  {
+    auto data = rmm::device_uvector<T>::data();
+    // May not need this
+    // if constexpr (std::is_integral_v<T>) {
+    cudf::experimental::prefetch::detail::prefetch(
+      "device_uvector::data", data, rmm::device_uvector<T>::size() * sizeof(T));
+    return data;
+  }
+
   /**
    * @brief Returns an iterator to the beginning of the allocation.
    *

diff --git a/cpp/src/utilities/device_uvector.cpp b/cpp/src/utilities/device_uvector.cpp