Skip to content

Commit

Permalink
Ensure include headers are marked with CUDF_EXPORT
Browse files Browse the repository at this point in the history
  • Loading branch information
robertmaynard committed Jul 17, 2024
1 parent c127579 commit 39186ae
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 33 deletions.
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/datetime.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

#include <memory>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace datetime {
namespace detail {
/**
Expand Down Expand Up @@ -174,4 +174,4 @@ std::unique_ptr<cudf::column> extract_quarter(cudf::column_view const& column,

} // namespace detail
} // namespace datetime
} // namespace cudf
} // namespace CUDF_EXPORT cudf
13 changes: 4 additions & 9 deletions cpp/include/cudf/detail/groupby.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@
#include <memory>
#include <utility>

namespace cudf {
namespace groupby {
namespace detail {
namespace hash {
namespace CUDF_EXPORT cudf {
namespace groupby::detail::hash {
/**
* @brief Indicates if a set of aggregation requests can be satisfied with a
* hash-based groupby implementation.
Expand All @@ -47,8 +45,5 @@ std::pair<std::unique_ptr<table>, std::vector<aggregation_result>> groupby(
null_policy include_null_keys,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr);
} // namespace hash

} // namespace detail
} // namespace groupby
} // namespace cudf
} // namespace groupby::detail::hash
} // namespace CUDF_EXPORT cudf
4 changes: 2 additions & 2 deletions cpp/include/cudf/detail/groupby/group_replace_nulls.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#include <rmm/exec_policy.hpp>
#include <rmm/resource_ref.hpp>
namespace cudf {
namespace CUDF_EXPORT cudf {
namespace groupby {
namespace detail {

Expand All @@ -45,4 +45,4 @@ std::unique_ptr<column> group_replace_nulls(cudf::column_view const& grouped_val

} // namespace detail
} // namespace groupby
} // namespace cudf
} // namespace CUDF_EXPORT cudf
12 changes: 4 additions & 8 deletions cpp/include/cudf/detail/groupby/sort_helper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,8 @@
#include <rmm/device_uvector.hpp>
#include <rmm/resource_ref.hpp>

namespace cudf {
namespace groupby {
namespace detail {
namespace sort {
namespace CUDF_EXPORT cudf {
namespace groupby::detail::sort {
/**
* @brief Helper class for computing sort-based groupby
*
Expand Down Expand Up @@ -229,7 +227,5 @@ struct sort_groupby_helper {
std::vector<null_order> _null_precedence; ///< How to sort NULLs
};

} // namespace sort
} // namespace detail
} // namespace groupby
} // namespace cudf
} // namespace groupby::detail::sort
} // namespace CUDF_EXPORT cudf
10 changes: 4 additions & 6 deletions cpp/include/cudf/detail/tdigest/tdigest.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,8 @@
#include <rmm/cuda_stream_view.hpp>
#include <rmm/resource_ref.hpp>

namespace cudf {
namespace tdigest {
namespace detail {
namespace CUDF_EXPORT cudf {
namespace tdigest::detail {

/**
* @brief Generate a tdigest column from a grouped, sorted set of numeric input values.
Expand Down Expand Up @@ -238,6 +237,5 @@ std::unique_ptr<scalar> reduce_merge_tdigest(column_view const& input,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr);

} // namespace detail
} // namespace tdigest
} // namespace cudf
} // namespace tdigest::detail
} // namespace CUDF_EXPORT cudf
6 changes: 2 additions & 4 deletions cpp/include/cudf/io/text/detail/bgzip_utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include <fstream>
#include <limits>

namespace cudf {
namespace CUDF_EXPORT cudf {
namespace io::text::detail::bgzip {

struct header {
Expand Down Expand Up @@ -91,7 +91,6 @@ void write_footer(std::ostream& output_stream, host_span<char const> data);
* BGZIP block size subfield
* @param post_size_subfields Any subfields to be placed after the BGZIP block size subfield
*/
CUDF_EXPORT
void write_uncompressed_block(std::ostream& output_stream,
host_span<char const> data,
host_span<char const> pre_size_subfields = {},
Expand All @@ -107,11 +106,10 @@ void write_uncompressed_block(std::ostream& output_stream,
* BGZIP block size subfield
* @param post_size_subfields Any subfields to be placed after the BGZIP block size subfield
*/
CUDF_EXPORT
void write_compressed_block(std::ostream& output_stream,
host_span<char const> data,
host_span<char const> pre_size_subfields = {},
host_span<char const> post_size_subfields = {});

} // namespace io::text::detail::bgzip
} // namespace cudf
} // namespace CUDF_EXPORT cudf
7 changes: 5 additions & 2 deletions cpp/include/cudf/strings/detail/merge.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@
#include <cudf/column/column.hpp>
#include <cudf/detail/merge.hpp>
#include <cudf/strings/strings_column_view.hpp>
#include <cudf/utilities/export.hpp>

#include <rmm/cuda_stream_view.hpp>

namespace cudf::strings::detail {
namespace CUDF_EXPORT cudf {
namespace strings::detail {
/**
* @brief Merges two strings columns
*
Expand All @@ -38,4 +40,5 @@ std::unique_ptr<column> merge(strings_column_view const& lhs,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr);

} // namespace cudf::strings::detail
} // namespace strings::detail
} // namespace CUDF_EXPORT cudf

0 comments on commit 39186ae

Please sign in to comment.