Skip to content

Commit

Permalink
rename final telemetry update job
Browse files Browse the repository at this point in the history
  • Loading branch information
msarahan committed Oct 29, 2024
1 parent 0608320 commit 2fb6bee
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ concurrency:
cancel-in-progress: true

env:
# TODO: put this in a shared org-wide secret?
OTEL_SERVICE_NAME: 'pr-cudf'
# TODO: this should be set as an org-wide variable
OTEL_EXPORTER_OTLP_ENDPOINT: https://tempo.gha-runners.nvidia.com:4318
Expand Down Expand Up @@ -152,7 +151,7 @@ jobs:
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@add-telemetry
with:
enable_check_generated_files: false
ignored_pr_jobs: "final_span_update"
ignored_pr_jobs: "final-telemetry-update"
default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
conda-cpp-build:
Expand Down Expand Up @@ -410,7 +409,7 @@ jobs:
run_script: "ci/cudf_pandas_scripts/pandas-tests/diff.sh"
default_endpoint: "${{needs.telemetry-setup.outputs.endpoint}}"
traceparent: ${{ needs.telemetry-setup.outputs.traceparent }}
final_span_update:
final-telemetry-update:
runs-on: ubuntu-latest
needs: [pr-builder, telemetry-setup]
steps:
Expand Down

0 comments on commit 2fb6bee

Please sign in to comment.