Skip to content

Commit

Permalink
Remove create_chars_child_column utility (#15241)
Browse files Browse the repository at this point in the history
Removes the `cudf::strings::detail::create_chars_child_column` utility. This is not longer needed or used.
Removing it helps prevent inadvertently using it to wrap chars data with a cudf column.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Muhammad Haseeb (https://github.com/mhaseeb123)
  - Yunsong Wang (https://github.com/PointKernel)

URL: #15241
  • Loading branch information
davidwendt authored Mar 8, 2024
1 parent 65fb218 commit 2ebfc80
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 21 deletions.
13 changes: 0 additions & 13 deletions cpp/include/cudf/strings/detail/utilities.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,6 @@
namespace cudf {
namespace strings {
namespace detail {
/**
* @brief Create a chars column to be a child of a strings column.
*
* This will return the properly sized column to be filled in by the caller.
*
* @param bytes Number of bytes for the chars column.
* @param stream CUDA stream used for device memory operations and kernel launches.
* @param mr Device memory resource used to allocate the returned column's device memory.
* @return The chars child column for a strings column.
*/
std::unique_ptr<column> create_chars_child_column(size_type bytes,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr);

/**
* @brief Creates a string_view vector from a strings column.
Expand Down
8 changes: 0 additions & 8 deletions cpp/src/strings/utilities.cu
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,6 @@ rmm::device_uvector<string_view> create_string_vector_from_column(
return strings_vector;
}

std::unique_ptr<column> create_chars_child_column(cudf::size_type total_bytes,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
{
return make_numeric_column(
data_type{type_id::INT8}, total_bytes, mask_state::UNALLOCATED, stream, mr);
}

namespace {
// The device variables are created here to avoid using a singleton that may cause issues
// with RMM initialize/finalize. See PR #3159 for details on this approach.
Expand Down

0 comments on commit 2ebfc80

Please sign in to comment.