Java review comments:

1. Removed extra whitespaces, unnecessary comments. 2. Fixed copyright date. 3. Reused `big()` helper function. 4. Updated `Scalar.equals()` to include DECIMAL128. Signed-off-by: MithunR <[email protected]>
rapidsai · Sep 13, 2022 · 283e76b · 283e76b
1 parent efa5b1a
commit 283e76b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/java/src/main/java/ai/rapids/cudf/Scalar.java b/java/src/main/java/ai/rapids/cudf/Scalar.java
@@ -1,6 +1,6 @@
 /*
  *
- *  Copyright (c) 2019-2021, NVIDIA CORPORATION.
+ *  Copyright (c) 2019-2022, NVIDIA CORPORATION.
  *
  *  Licensed under the Apache License, Version 2.0 (the "License");
  *  you may not use this file except in compliance with the License.
@@ -754,6 +754,8 @@ public boolean equals(Object o) {
     case TIMESTAMP_NANOSECONDS:
     case DECIMAL64:
       return getLong() == other.getLong();
+    case DECIMAL128:
+      return getBigDecimal().equals(other.getBigDecimal());
     case STRING:
       return Arrays.equals(getUTF8(), other.getUTF8());
     case LIST:

diff --git a/java/src/test/java/ai/rapids/cudf/TableTest.java b/java/src/test/java/ai/rapids/cudf/TableTest.java
@@ -4006,8 +4006,6 @@ void testWindowingCount() {
     }
   }
 
-
-
   @Test
   void testWindowingMin() {
     try (Table unsorted = new Table.TestBuilder()
@@ -4964,8 +4962,6 @@ void testWindowingOnMultipleDifferentColumns() {
     }
   }
 
-  // Test Decimal OBY column with Range queries.
-
   @Test
   void testWindowingWithoutGroupByColumns() {
     try (Table unsorted = new Table.TestBuilder().column( 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6) // OBY Key
@@ -5806,7 +5802,7 @@ private static Scalar getDecimalScalarRangeBounds(int scale, int unscaledValue,
     {
       case 2: return Scalar.fromDecimal(scale, unscaledValue);
       case 3: return Scalar.fromDecimal(scale, Long.valueOf(unscaledValue));
-      case 4: return Scalar.fromDecimal(scale, new BigInteger("" + unscaledValue));
+      case 4: return Scalar.fromDecimal(scale, big(unscaledValue));
       default: 
         throw new IllegalStateException("Unexpected order by column index: " 
                                         + orderby_col_idx);