Skip to content

Commit

Permalink
Correct issues found by CI
Browse files Browse the repository at this point in the history
  • Loading branch information
robertmaynard committed Jul 1, 2024
1 parent 45b14d3 commit 1cf3204
Showing 1 changed file with 25 additions and 11 deletions.
36 changes: 25 additions & 11 deletions cpp/tests/streams/merge_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,11 @@ TYPED_TEST(MergeTest_, MergeIsZeroWhenShouldNotBeZero)
cudf::table_view right_view{{rightColWrap1}};
cudf::table_view expected{{leftColWrap1}};

auto result = cudf::merge({left_view, right_view}, key_cols, column_order, null_precedence);
auto result = cudf::merge({left_view, right_view}, key_cols, column_order, null_precedence, cudf::test::get_default_stream());
auto result = cudf::merge({left_view, right_view},
key_cols,
column_order,
null_precedence,
cudf::test::get_default_stream());

int expected_len = 5;
ASSERT_EQ(result->num_rows(), expected_len);
Expand Down Expand Up @@ -103,17 +106,28 @@ TEST_F(MergeTest, KeysWithNulls)
for (auto np : null_precedences) {
std::vector<cudf::order> column_order{co};
std::vector<cudf::null_order> null_precedence{np};
auto sorted1 =
cudf::sort(cudf::table_view({data1}), column_order, null_precedence, cudf::test::get_default_stream())->release();
auto col1 = sorted1.front()->view();
auto sorted2 =
cudf::sort(cudf::table_view({data2}), column_order, null_precedence, cudf::test::get_default_stream())->release();
auto sorted1 = cudf::sort(cudf::table_view({data1}),
column_order,
null_precedence,
cudf::test::get_default_stream())
->release();
auto col1 = sorted1.front()->view();
auto sorted2 = cudf::sort(cudf::table_view({data2}),
column_order,
null_precedence,
cudf::test::get_default_stream())
->release();
auto col2 = sorted2.front()->view();

auto result = cudf::merge(
{cudf::table_view({col1}), cudf::table_view({col2})}, {0}, column_order, null_precedence, cudf::test::get_default_stream());
auto sorted_all =
cudf::sort(cudf::table_view({all_data->view()}), column_order, null_precedence, cudf::test::get_default_stream());
auto result = cudf::merge({cudf::table_view({col1}), cudf::table_view({col2})},
{0},
column_order,
null_precedence,
cudf::test::get_default_stream());
auto sorted_all = cudf::sort(cudf::table_view({all_data->view()}),
column_order,
null_precedence,
cudf::test::get_default_stream());
CUDF_TEST_EXPECT_COLUMNS_EQUAL(sorted_all->view().column(0), result->view().column(0));
}
}
Expand Down

0 comments on commit 1cf3204

Please sign in to comment.