Update python/cudf/cudf/core/tools/numeric.py

Co-authored-by: Matthew Murray <[email protected]>
rapidsai · Dec 9, 2024 · 182f6d9 · 182f6d9
1 parent 4974bef
commit 182f6d9
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/python/cudf/cudf/core/tools/numeric.py b/python/cudf/cudf/core/tools/numeric.py
@@ -226,6 +226,8 @@ def _convert_str_col(
     if col.is_integer().all():
         return col.astype(dtype=cudf.dtype("i8"))  # type: ignore[return-value]
 
+    # TODO: This can be handled by libcudf in
+    # future see StringColumn.as_numerical_column
     converted_col = (
         col.to_lower()
         .find_and_replace(as_column([""]), as_column(["NaN"]))