add include/libcudf/libcudaxx to install_include_directories

rapidsai · Mar 16, 2021 · 12e09c0 · 12e09c0
1 parent 0e75e0f
commit 12e09c0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
@@ -421,7 +421,8 @@ target_include_directories(cudf
                        "$<BUILD_INTERFACE:${CUDF_SOURCE_DIR}/include>"
                        "$<BUILD_INTERFACE:${CUDF_GENERATED_INCLUDE_DIR}/include>"
            PRIVATE     "$<BUILD_INTERFACE:${CUDF_SOURCE_DIR}/src>"
-           INTERFACE   "$<INSTALL_INTERFACE:include>")
+           INTERFACE   "$<INSTALL_INTERFACE:include>"
+                       "$<INSTALL_INTERFACE:include/libcudf/libcudaxx>")
 
 # Add Conda library paths if specified
 if(CONDA_LINK_DIRS)

diff --git a/cpp/cmake/cudf-config.cmake.in b/cpp/cmake/cudf-config.cmake.in
@@ -19,15 +19,9 @@ find_dependency(Arrow @CUDF_VERSION_Arrow@)
 find_dependency(ArrowCUDA @CUDF_VERSION_Arrow@)
 find_dependency(Boost @CUDF_MIN_VERSION_Boost@)
 
-# find_dependency(jitify)
 find_dependency(rmm @CUDF_MIN_VERSION_rmm@)
-# find_dependency(Thrust @CUDF_MIN_VERSION_Thrust@)
-# find_dependency(dlpack @CUDF_MIN_VERSION_dlpack@)
-# find_dependency(libcudacxx @CUDF_MIN_VERSION_libcudacxx@)
 find_dependency(gtest @CUDF_MIN_VERSION_gtest@)
 
-# thrust_create_target(cudf::Thrust FROM_OPTIONS)
-
 list(POP_FRONT CMAKE_MODULE_PATH)
 
 include("${CMAKE_CURRENT_LIST_DIR}/cudf-targets.cmake")

diff --git a/cpp/cmake/thirdparty/CUDF_GetCPM.cmake b/cpp/cmake/thirdparty/CUDF_GetCPM.cmake
@@ -18,6 +18,8 @@ endif()
 
 include(${CPM_DOWNLOAD_LOCATION})
 
+# If a target is installed, found by the `find_package` step of CPMFindPackage,
+# and marked as IMPORTED, make it globally accessible to consumers of our libs.
 function(fix_cmake_global_defaults target)
     if(TARGET ${target})
         get_target_property(_is_imported ${target} IMPORTED)