Skip to content

Commit

Permalink
Merge branch 'rwlee/row_op_split' of github.com:rwlee/cudf into rwlee…
Browse files Browse the repository at this point in the history
…/row_op_split
  • Loading branch information
rwlee committed May 10, 2022
2 parents 4d197ea + 84833e7 commit 08092fe
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cpp/include/cudf/table/experimental/row_operators.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ namespace lexicographic {
*/
template <typename Nullate>
class device_row_comparator {
// friend class device_less_comparator<Nullate>;
friend class self_comparator;
/**
* @brief Construct a function object for performing a lexicographic
Expand Down Expand Up @@ -281,6 +280,9 @@ class device_row_comparator {
* @brief Wraps and interprets the result of templated Comparator that returns a weak_ordering.
* Returns true if the weak_ordering matches any of the templated values.
*
* Note that this should never be used with only `weak_ordering::EQUIVALENT`.
* An equality comparator should be used instead for optimal performance.
*
* @tparam Comparator generic comparator that returns a weak_ordering.
* @tparam values weak_ordering parameter pack of orderings to interpret as true
*/
Expand Down

0 comments on commit 08092fe

Please sign in to comment.