Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper bound to prevent usage of NumPy 2 #712

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 12, 2024

NumPy 2 is expected to be released in the near future. For the RAPIDS 24.04 release, we will pin to numpy>=1.23,<2.0a0. This PR adds an upper bound to affected RAPIDS repositories.

xref: rapidsai/build-planning#29

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Mar 12, 2024
@bdice bdice marked this pull request as ready for review March 12, 2024 22:33
@bdice bdice requested a review from a team as a code owner March 12, 2024 22:33
@jakirkham
Copy link
Member

Thanks Bradley! 🙏

Could we add this to wheels too? Looks like it is Conda only atm

@bdice bdice requested a review from a team as a code owner March 12, 2024 23:05
@bdice
Copy link
Contributor Author

bdice commented Mar 12, 2024

Wheels added in d7d067e.

@jakirkham
Copy link
Member

Looks good. Thanks Bradley! 🙏

@bdice
Copy link
Contributor Author

bdice commented Mar 13, 2024

/merge

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@rapids-bot rapids-bot bot merged commit 1874f49 into rapidsai:branch-24.04 Mar 13, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants