Fix return_error='always' behavior in phase_cross_correlation
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grlee77
added
bug
grlee77
force-pushed
the
shift_length_mismatch_debug
branch
from
16263b0 to
71bf264
Compare
grlee77
changed the title
return_error='always' behavior in phase_cross_correlation
jakirkham
approved these changes
Apr 27, 2023
|
/merge |
|
Thanks Greg! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR updates behavior of the
return_errorargument to match the final version implemented in scikit-image 0.20.It also fixes a test suite error seen when recent
imageiocauses one of the test images to be loaded as RGB instead of grayscale.