-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize whitespace. #474
Conversation
Issue ( #484 ) has been addressed in Also added labels to fix the label checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Looks like the CI failure is probably an unrelated network issue (failed download). I restarted the failed jobs to see if it goes through on the second round.
Thanks, @bdice |
Toggling for CI |
@gpucibot merge |
@jakirkham, the Please re-comment this PR with |
/merge |
@@ -14,4 +14,3 @@ index 7da31f7..5816de7 100644 | |||
+ //BOOST_ASSERT(0 == ((std::size_t)ret % ::boost::container::dtl::alignment_of<T>::value)); | |||
return static_cast<T*>(ret); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we want to keep this line. Otherwise the patch doesn't apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted in commit ( 43606cf )
Looks like the style check doesn't like that change 😂 If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/cpp/cmake/deps/boost-header-only.patch b/cpp/cmake/deps/boost-header-only.patch
index e765790..96c0078 100644
--- a/cpp/cmake/deps/boost-header-only.patch
+++ b/cpp/cmake/deps/boost-header-only.patch
@@ -14,4 +14,3 @@ index 7da31f7..5816de7 100644
+ //BOOST_ASSERT(0 == ((std::size_t)ret % ::boost::container::dtl::alignment_of<T>::value));
return static_cast<T*>(ret);
}
- Maybe we can skip this file during style checking? |
Co-authored-by: Bradley Dice <[email protected]>
Thanks all! 🙏 |
This PR re-enables pre-commit checks for normalizing whitespace (trimming trailing spaces) that I disabled in #471.
These pre-commit hooks existed prior to the GitHub Actions migration but they were not being enforced by CI style checks. I disabled them in #471 because enforcing them would have made the PR diff large.
The primary change is in
.pre-commit-config.yaml
, and everything else was automatically fixed bypre-commit
.