Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install CUDA packages on CUDA 11. #77

Merged
merged 7 commits into from
Oct 16, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Oct 4, 2023

This PR changes CUDA 12 ci-conda images so that they don't install CUDA Toolkit packages. For CUDA 12 conda images, we should fetch the relevant CUDA Toolkit packages from conda-forge and don't need a full system CUDA Toolkit.

Resolves https://github.com/rapidsai/ops/issues/2565.

@bdice bdice marked this pull request as ready for review October 4, 2023 03:14
@bdice
Copy link
Contributor Author

bdice commented Oct 4, 2023

cc: @jakirkham @ajschmidt8 @raydouglass for your thoughts on this.

@bdice bdice self-assigned this Oct 4, 2023
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Generally seems reasonable

Would it make sense to add message for the other cases as well?

ci-conda.Dockerfile Show resolved Hide resolved
ci-conda.Dockerfile Show resolved Hide resolved
ci-conda.Dockerfile Outdated Show resolved Hide resolved
@jakirkham
Copy link
Member

Looks like a couple builds might need restarts

@raydouglass
Copy link
Member

We should wait to merge this until after the 23.10 release which is scheduled for tomorrow.

@raydouglass raydouglass merged commit b4dcc68 into rapidsai:main Oct 16, 2023
211 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Oct 19, 2023
…or new CI containers (#14296)

The aws-sdk-cpp pinning introduced in #14173 causes problems because newer builds of libarrow require a newer version of aws-sdk-cpp. Even though we restrict to libarrow 12.0.1, this restriction is insufficient to create solvable environments because the conda (mamba) solver doesn't seem to consistently reach far back enough into the history of builds to pull the last build that was compatible with the aws-sdk-cpp version that we need. For now, the safest way for us to avoid this problem is to downgrade to arrow 12.0.0, for which all conda package builds are pinned to the older version of aws-sdk-cpp that does not have the bug in question.

Separately, while the above issue was encountered we also got new builds of our CI images [that removed system installs of CTK packages from CUDA 12 images](rapidsai/ci-imgs#77). This changes was made because for CUDA 12 we can get all the necessary pieces of the CTK from conda-forge. However, it turns out that the cudf_kafka builds were implicitly relying on system CTK packages, and the cudf_kafka build is in fact not fully compatible with conda-forge CTK packages because it is not using CMake via scikit-build (nor any other more sophisticated library discovery mechanism like pkg-config) and therefore does not know how to find conda-forge CTK headers/libraries. This PR introduces a set of temporary patches to get around this limitation. These patches are not a long-term fix, and are only put in place assuming that #14292 is merged in the near future before we cut a 23.12 release.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Ray Douglass (https://github.com/raydouglass)

URL: #14296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants