Add sccache and cmake env vars to images
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some common `sccache` and `cmake` environment variables to our CI images so that they don't need to be defined in each individual repository.
ajschmidt8
added a commit
to ajschmidt8/rmm
that referenced
this pull request
Nov 9, 2022
This PR removes some environment variables that will now be defined in our CI images once rapidsai/ci-imgs#19 is merged. Depends on rapidsai/ci-imgs#19.
3 tasks
raydouglass
approved these changes
Nov 9, 2022
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Nov 9, 2022
This PR removes some environment variables that will now be defined in our CI images once rapidsai/ci-imgs#19 is merged. Additionally, it adds `ninja` to our `build` requirements since `ninja` was removed from our CI images. Depends on rapidsai/ci-imgs#19 and rapidsai/ci-imgs#20. Authors: - AJ Schmidt (https://github.com/ajschmidt8) Approvers: - https://github.com/jakirkham - Robert Maynard (https://github.com/robertmaynard) - Ray Douglass (https://github.com/raydouglass) URL: #1155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some common
sccacheandcmakeenvironment variables to our CI images so that they don't need to be defined in each individual repository.