Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary build arg in ci-wheel Dockerfile #100

Merged
merged 8 commits into from
Dec 20, 2023

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#7.

Removes one unnecessary build argument in the ci-wheel Dockerfile.

Since build arg REAL_ARCH isn't used in this FROM, specifying it before that has no effect:

ARG REAL_ARCH=x86_64
ARG BASE_IMAGE=nvcr.io/nvidia/cuda:${CUDA_VER}-devel-${LINUX_VER}

Per https://docs.docker.com/engine/reference/builder/#scope

An ARG instruction goes out of scope at the end of the build stage where it was defined.

@jameslamb jameslamb marked this pull request as draft December 18, 2023 22:29
@jameslamb jameslamb marked this pull request as ready for review December 19, 2023 23:02
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems like the CPU_ARCH is used once (for downloading sccache)

ci-wheel.Dockerfile Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Dec 19, 2023

Also related question, is it possible to infer CPU_ARCH from REAL_ARCH or vice versa? I always forget the fine points of the differences between things like x86_64 and amd64.

@ajschmidt8
Copy link
Member

Also related question, is it possible to infer CPU_ARCH from REAL_ARCH or vice versa? I always forget the fine points of the differences between things like x86_64 and amd64.

There's likely some additional refactoring that can be done here, but we can save that for the future. Divye and I had a chat about this a while ago too.

For now, we'll merge this change as it is.

Thanks, James!

@ajschmidt8 ajschmidt8 merged commit 1578d9b into rapidsai:main Dec 20, 2023
277 checks passed
@jameslamb jameslamb deleted the remove-build-arg branch December 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants