-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary build arg in ci-wheel Dockerfile #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems like the CPU_ARCH
is used once (for downloading sccache)
Also related question, is it possible to infer |
There's likely some additional refactoring that can be done here, but we can save that for the future. Divye and I had a chat about this a while ago too. For now, we'll merge this change as it is. Thanks, James! |
Contributes to rapidsai/build-planning#7.
Removes one unnecessary build argument in the
ci-wheel
Dockerfile.Since build arg
REAL_ARCH
isn't used in thisFROM
, specifying it before that has no effect:ci-imgs/ci-wheel.Dockerfile
Lines 3 to 5 in a02c2e8
Per https://docs.docker.com/engine/reference/builder/#scope