Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Python directory test to tests #140

Closed
jakirkham opened this issue Jan 17, 2025 · 1 comment · Fixed by rapidsai/cuvs#590
Closed

Rename Python directory test to tests #140

jakirkham opened this issue Jan 17, 2025 · 1 comment · Fixed by rapidsai/cuvs#590

Comments

@jakirkham
Copy link
Member

...we should consider making cuvs match the rest of RAPIDS and use the name "tests" for this folder.

See:

pylibraft and raft-dask are also exceptions here:

Originally posted by @bdice in rapidsai/cuvs#584 (review)
@jakirkham jakirkham mentioned this issue Jan 17, 2025
Merged
This was referenced Jan 18, 2025
Merged
Merged
Merged
@bdice
Copy link
Contributor

bdice commented Jan 18, 2025

I filed 3 PRs to RAFT, cuVS, and cuML to standardize our test directories to use the name tests.

rapids-bot bot referenced this issue in rapidsai/raft Jan 23, 2025
@bdice
Rename test to tests. (#2546)
0eff235 
Renames `test` directories to `tests` for alignment with the rest of RAPIDS.

See also: https://github.com/rapidsai/cuvs/issues/587

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #2546
@jakirkham jakirkham transferred this issue from rapidsai/cuvs Jan 24, 2025
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this issue Jan 24, 2025
@bdice
Rename cpp/test to cpp/tests. (#6237)
c262f1f 
Renames `test` directories to `tests` for alignment with the rest of RAPIDS.

See also: rapidsai/build-planning#140

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #6237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename test to tests. bdice/cuvs
2 participants
@jakirkham @bdice