Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session status to message #356

Merged
merged 12 commits into from
Sep 14, 2020
Merged

Conversation

kitandara
Copy link

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #356 into master will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #356      +/-   ##
==========================================
- Coverage   54.76%   54.76%   -0.01%     
==========================================
  Files         108      108              
  Lines        8914     8917       +3     
==========================================
+ Hits         4882     4883       +1     
- Misses       3330     3332       +2     
  Partials      702      702              
Impacted Files Coverage Δ
models/msgs.go 20.62% <0.00%> (-0.10%) ⬇️
hooks/msg_created.go 54.54% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a6f44...760ad26. Read the comment docs.

@@ -130,6 +130,8 @@ type Msg struct {
SessionID SessionID `json:"session_id,omitempty"`
SessionWaitStartedOn *time.Time `json:"session_wait_started_on,omitempty"`
SessionTimeout int `json:"session_timeout,omitempty"`
// Transmit sessionstatus onwards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this comment.. everything here is being transmitted onwards

@rowanseymour rowanseymour merged commit c58e923 into rapidpro:master Sep 14, 2020
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants