Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop writing is_blocked and is_stopped #343

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Stop writing is_blocked and is_stopped #343

merged 1 commit into from
Aug 25, 2020

Conversation

rowanseymour
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 25, 2020 •
edited
Loading

Codecov Report

Merging #343 into master will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
- Coverage   54.52%   54.51%   -0.02%     
==========================================
  Files         106      106              
  Lines        8855     8853       -2     
==========================================
- Hits         4828     4826       -2     
  Misses       3335     3335              
  Partials      692      692
Impacted Files Coverage Δ
models/contacts.go 55.95% <66.66%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286acd1...035b0d7. Read the comment docs.

@rowanseymour rowanseymour merged commit 3f5f1d2 into master Aug 25, 2020
@rowanseymour rowanseymour deleted the contact_status_pt3 branch August 25, 2020 17:34
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Mar 10, 2023
@nicpottier
Merge pull request rapidpro#343 from nyaruka/local-fail-cache
23a0f54 
Local fail cache
rasoro pushed a commit to Ilhasoft/mailroom that referenced this pull request Jan 21, 2025
@rowanseymour
Merge pull request rapidpro#343 from nyaruka/bcast_started
78b4cb9 
Mark broadcasts as started once recipients are known and update contact_count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpottier nicpottier Awaiting requested review from nicpottier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rowanseymour