🗽 Read from contact.status instead of is_stopped/is_blocked #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
commented
Aug 24, 2020
| // contact has been deleted or is blocked, ignore this event | ||
| if len(contacts) == 0 || contacts[0].IsBlocked() { | ||
| // contact has been deleted or is blocked/stopped/archived, ignore this event | ||
| if len(contacts) == 0 || contacts[0].Status() != models.ContactStatusActive { |
There was a problem hiding this comment.
so technically a change of behaviour.. but seems stopped contacts shouldn't get timed events same as blocked?
rowanseymour
force-pushed
the
contact_status_pt2
branch
from
ce00f39 to
94eb7ed
Compare
rowanseymour
commented
Aug 24, 2020
| ContactStatusActive: flows.ContactStatusActive, | ||
| ContactStatusBlocked: flows.ContactStatusBlocked, | ||
| ContactStatusStopped: flows.ContactStatusStopped, | ||
| ContactStatusArchived: flows.ContactStatusArchived, |
There was a problem hiding this comment.
writing this had me wondering if single char codes were worth it in the db.. but then writing https://github.com/nyaruka/rapidpro/pull/2926/files#diff-3e440a4651b73b0746e52e4bcf4376f4R30-R31 convinced it was fine to be consistent for now
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 54.49% 54.52% +0.02%
==========================================
Files 106 106
Lines 8863 8855 -8
==========================================
- Hits 4830 4828 -2
+ Misses 3339 3335 -4
+ Partials 694 692 -2
Continue to review full report at Codecov.
|
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
add textit whatsapp channel type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.