🌚 Contact creation endpoint #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 54.51% 54.68% +0.17%
==========================================
Files 106 107 +1
Lines 8853 8942 +89
==========================================
+ Hits 4826 4890 +64
- Misses 3335 3352 +17
- Partials 692 700 +8
Continue to review full report at Codecov.
|
rowanseymour
force-pushed
the
contact_create
branch
2 times, most recently
from
17e51c6 to
eaac133
Compare
rowanseymour
force-pushed
the
contact_create
branch
from
eaac133 to
ece5169
Compare
rowanseymour
commented
Jul 2, 2020
| @@ -611,8 +612,82 @@ func ContactIDsFromURNs(ctx context.Context, db *sqlx.DB, org *OrgAssets, us []u | |||
| } | |||
|
|
|||
| // CreateContact creates a new contact for the passed in org with the passed in URNs | |||
| func CreateContact(ctx context.Context, db *sqlx.DB, org *OrgAssets, urn urns.URN) (ContactID, error) { | |||
| // we have a URN, first try to look up the URN | |||
| func CreateContact(ctx context.Context, db *sqlx.DB, org *OrgAssets, userID UserID, name string, language envs.Language, urnz []urns.URN) (*Contact, *flows.Contact, error) { | |||
There was a problem hiding this comment.
there's a bit of repetition but feels worth it to keep the create vs get_or_create pathways separate since there are many little ways in which they end up different
There was a problem hiding this comment.
Nice, this looks good and nice job dealing with all the conflicts elegantly.
rowanseymour
commented
Jul 3, 2020
web/contact/contact.go
Outdated
| oa, err = oa.Clone(s.CTX, s.DB) | ||
| if err != nil { | ||
| return nil, http.StatusInternalServerError, errors.Wrapf(err, "unable to clone orgs") | ||
| } |
There was a problem hiding this comment.
assume this was just mistakenly copied from simulator endpoint - this endpoint shouldn't be modifying any assets
nicpottier
approved these changes
Aug 24, 2020
| @@ -611,8 +612,82 @@ func ContactIDsFromURNs(ctx context.Context, db *sqlx.DB, org *OrgAssets, us []u | |||
| } | |||
|
|
|||
| // CreateContact creates a new contact for the passed in org with the passed in URNs | |||
| func CreateContact(ctx context.Context, db *sqlx.DB, org *OrgAssets, urn urns.URN) (ContactID, error) { | |||
| // we have a URN, first try to look up the URN | |||
| func CreateContact(ctx context.Context, db *sqlx.DB, org *OrgAssets, userID UserID, name string, language envs.Language, urnz []urns.URN) (*Contact, *flows.Contact, error) { | |||
There was a problem hiding this comment.
Nice, this looks good and nice job dealing with all the conflicts elegantly.
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Mar 10, 2023
HX channel sends MO using ISO 8859-1 encoding
rasoro
pushed a commit
to Ilhasoft/mailroom
that referenced
this pull request
Jan 21, 2025
Update test database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.