Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please add a pinned Rust version to CI #26

Closed
BurntSushi opened this issue Oct 29, 2018 · 2 comments
Closed

please add a pinned Rust version to CI #26

BurntSushi opened this issue Oct 29, 2018 · 2 comments

Comments

@BurntSushi
Copy link

The latest release of strsim (0.8) increased its minimum required Rust version to build. There is no problem with that, but in doing so, I'd now like to increase my minimum Rust version in my CI config to accommodate the strsim update. In order to do that, I need to know what Rust version strsim compiles with. In the ecosystem, one convention used to communicate this is to add a specific Rust version in the CI config. Here is an example: https://github.com/BurntSushi/byteorder/blob/bdcc6bf676a1ed17eae68257bfa4726a1f0ec068/.travis.yml#L4

Could you please add a pinned version to your CI config? (Note that I am not asking for any specific semver policy around the minimum Rust version supported, but rather, just a somewhat more structured means of communicating what version of Rust strsim compiles with.)

@BurntSushi
Copy link
Author

Thanks!

@dguo
Copy link
Member

dguo commented Oct 30, 2018

No problem.

It didn't occur to me that Cargo doesn't have a way of specifying Rust versions in the way npm does. I found this RFC and some of your earlier discussion on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants