Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Semantic Versioning #1

Merged
merged 3 commits into from
Feb 17, 2015
Merged

Conversation

jlee-r7
Copy link
Contributor

@jlee-r7 jlee-r7 commented Feb 12, 2015

This is kind of a proxy pull request so there will be something to review for minimum acceptance of this repo. The following steps cover code not contained in this PR.

Verification

Authentication

  • Have a Windows 2012 VM
  • open wireshark
  • bundle exec irb -r smb2/client
  • [ ]
sock = TCPSocket.new("192.168.100.156", 445)
c = Smb2::Client.new(socket: sock, username:"administrator", password:"P@ssword1")
c.negotiate
c.authenticate
  • authenticate returns 0 (STATUS_SUCCESS)
  • Verify Wireshark shows a successful authentication (GSS-API negResult = accept-completed)

Documentation

Make sure the yard extension for bit-struct is working:

  • rake yard
  • Verify 256 methods
  • Verify 85% coverage
  • open doc/Smb2/Packet/WriteRequest.html in a browser
    • Verify the channel_info method has return type Strinng
    • Verify the channel_info_length and channel_info_offset are documented

@jlee-r7
Copy link
Contributor Author

jlee-r7 commented Feb 12, 2015

Bah, forgot about a change I had to make in metasploit-version because of the different namespace.

@jlee-r7
Copy link
Contributor Author

jlee-r7 commented Feb 12, 2015

Blocked by rapid7/metasploit-version#5

trosen-r7 added a commit that referenced this pull request Feb 17, 2015
@trosen-r7 trosen-r7 merged commit 277ce33 into rapid7:master Feb 17, 2015
@trosen-r7
Copy link
Contributor

Went ahead and merged this, on the idea that all will be passing w/ the landed change to Metasploit Version and knowing that this has no consumers currently.

@jlee-r7 jlee-r7 deleted the feature/MSP-12002/semver branch April 16, 2015 13:50
cdelafuente-r7 referenced this pull request in cdelafuente-r7/ruby_smb Apr 1, 2020
bwatters-r7 pushed a commit that referenced this pull request Nov 13, 2023
smcintyre-r7 pushed a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants