Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a proxy pull request so there will be something to review for minimum acceptance of this repo. The following steps cover code not contained in this PR.
Verification
Authentication
bundle exec irb -r smb2/client
authenticate
returns0
(STATUS_SUCCESS)Documentation
Make sure the yard extension for bit-struct is working:
rake yard
doc/Smb2/Packet/WriteRequest.html
in a browserchannel_info
method has return typeStrinng
channel_info_length
andchannel_info_offset
are documented