Expose supported proxies #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcintyre-r7
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Related to my comment here, I think we want to differentiate between SOCKS4 and SOCKS4A. SOCKS4A is a superset of functionality that permits connecting by hostname, but an IPv4 address is required if it's SOCKS4.
|
Agreed 👍 I've just created a new ticket to update rex-socket to support socks4a to unblock this effort #70 👍 |
|
@smcintyre-r7 Is this PR good to go in isolation or are there additional changes to make 👀 |
smcintyre-r7
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose supported proxies for consumption in Metasploit framework
rapid7/metasploit-framework#19683