Renames LDAP datastore options

[cgranleese-r7]

Note

This PR is required for another PR with Pro - https://github.com/rapid7/pro/pull/3808

This PR renames the LDAP datastore options to facilitate some changes being made in Pro as part of the following PR.

The reason this was required was due to adding the previous LDAP datastore values into the configuration hash within Pro in the following file - ui/app/models/scan_task.rb, this would result in duplicate hash keys as previous LDAP used:

• USERNAME
• PASSWORD
• DOMAIN

So I decided to align with how SMB was handling its datastore by updating them to be:

• LDAPUsername
• LDAPPassword
• LDAPDomain

Verification

• Run auxiliary/scanner/ldap/ldap_login against an ldap server to get a session (an example of running an ldap container can be found in the ldap acceptance tests here

  metasploit-framework/.github/workflows/ldap_acceptance.yml

  Lines 67 to 71 in 33ffc14

  	- name: Run samba/ldap docker container
  	working-directory: 'test/ldap'
  	run: |
  	docker compose build
  	docker compose up --wait -d

• Run SPEC_OPTS='--tag acceptance' SPEC_HELPER_LOAD_METASPLOIT=false bundle exec rspec ./spec/acceptance/ldap_spec.rb and ensure those pass locally.
• Start msfconsole
• Test ldap_login module
• Code changes are sane