-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SOAR-18656] Mimecast V2 #3066
Merged
Merged
[SOAR-18656] Mimecast V2 #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorski-r7
reviewed
Jan 28, 2025
rbowden-r7
reviewed
Jan 28, 2025
plugins/mimecast_v2/icon_mimecast_v2/tasks/monitor_siem_logs/task.py
Outdated
Show resolved
Hide resolved
rbowden-r7
reviewed
Jan 28, 2025
plugins/mimecast_v2/icon_mimecast_v2/tasks/monitor_siem_logs/task.py
Outdated
Show resolved
Hide resolved
igorski-r7
approved these changes
Jan 29, 2025
rbowden-r7
approved these changes
Jan 29, 2025
Comment on lines
+186
to
+191
if isinstance(query_date, str): | ||
query_date = datetime.strptime(query_date, "%Y-%m-%d").date() | ||
if (not log_type_config.get("caught_up")) or query_date < now_date: | ||
has_more_pages = True | ||
log_type_config["query_date"] = query_date.strftime("%Y-%m-%d") | ||
state["query_config"] = query_config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be worth making "%Y-%m-%d"
as a constant at the top as its used a few times throughout
ablakley-r7
added a commit
that referenced
this pull request
Feb 4, 2025
* Initial task code * Format api.py * Refactor task * Validators * Update state * Add todo. Update state handling. * Update version
rbowden-r7
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Initial task code * Format api.py * Refactor task * Validators * Update state * Add todo. Update state handling. * Update version
ablakley-r7
added a commit
that referenced
this pull request
Feb 5, 2025
* Initial task code * Format api.py * Refactor task * Validators * Update state * Add todo. Update state handling. * Update version
ablakley-r7
added a commit
that referenced
this pull request
Feb 5, 2025
* [SOAR-18655] Mimecast V2 (#3063) * Initial plugin * Initial plugin * [SOAR-18656] Mimecast V2 (#3066) * Initial task code * Format api.py * Refactor task * Validators * Update state * Add todo. Update state handling. * Update version * [SOAR-18657] mimecast v2 (#3068) * Update threads, error handling, custom config, rate limiting * Add connection test * Fix lint * Add unit tests * Add unit tests * Fix requiremnts * Fix requiremnts * Mimecast V2 - Fix connection test | Fix custom config (#3071) * Fix connection test | Fix custom config * Fix type hint * Add tooltip (#3074)
ablakley-r7
added a commit
that referenced
this pull request
Feb 5, 2025
* Initial task code * Format api.py * Refactor task * Validators * Update state * Add todo. Update state handling. * Update version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
Review our documentation on generating and writing plugin unit tests
In-Product Tests
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR