Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Soar 17409] - Microsoft Teams - Adding fedramp true flag #2805

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

rbowden-r7
Copy link
Collaborator

Proposed Changes

Description

Describe the proposed changes:

https://rapid7.atlassian.net/browse/SOAR-17409

  • Adding the fedramp true flag
  • Adding in a option for the user to select what endpoints they want to connect to, normal, gcc, gcc high and MoD
  • Bumping the SDK to version 6.1.2
  • Bumping the version of zipp used to address a snyk issue

PR Requirements

Developers, verify you have completed the following items by checking them off:

Testing

Unit Tests

The unit tests have been updated to now include the resource url

Review our documentation on generating and writing plugin unit tests

  • Unit tests written for any new or updated code

In-Product Tests

Testing has been done locally with both actions and triggers and all works as expected

If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:

  • Screenshot of job output with the plugin changes
  • Screenshot of the changed connection, actions, or triggers input within the InsightConnect workflow builder

Style

Review the style guide

  • For dependencies, pin OS package and Python package versions
  • For security, set least privileged account with USER nobody in the Dockerfile when possible
  • For size, use the slim SDK images when possible: rapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num} and rapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
  • For error handling, use of PluginException and ConnectionTestException
  • For logging, use self.logger
  • For docs, use changelog style
  • For docs, validate markdown with insight-plugin validate which calls icon_validate to lint help.md

Functional Checklist

  • Work fully completed
  • Functional
    • Any new actions/triggers include JSON test files in the tests/ directory created with insight-plugin samples
    • Tests should all pass unless it's a negative test. Negative tests have a naming convention of tests/$action_bad.json
    • Unsuccessful tests should fail by raising an exception causing the plugin to die and an object should be returned on successful test
    • Add functioning test results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -T tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run -T all --debug --jq (use PR format at end)
    • Add functioning run results to PR, sanitize any output if necessary
      • Single action/trigger insight-plugin run -R tests/example.json --debug --jq
      • All actions/triggers shortcut insight-plugin run --debug --jq (use PR format at end)

Assessment

You must validate your work to reviewers:

  1. Run insight-plugin validate and make sure everything passes
  2. Run the assessment tool: insight-plugin run -A. For single action validation: insight-plugin run tests/{file}.json -A
  3. Copy (insight-plugin ... | pbcopy) and paste the output in a new post on this PR
  4. Add required screenshots from the In-Product Tests section

Copy link
Collaborator

@igorski-r7 igorski-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 Left a small suggestions

@rbowden-r7 rbowden-r7 merged commit 273da2c into develop Sep 20, 2024
10 checks passed
ekelly-r7 pushed a commit that referenced this pull request Sep 24, 2024
* SOAR-17409-Adding fedramp ready flag to plugin

* SOAR-17409-Adding timeouts to the requests

* SOAR-17409-Addnf deafult to endpoint
rbowden-r7 added a commit that referenced this pull request Sep 26, 2024
* SOAR-17409-Adding fedramp ready flag to plugin

* SOAR-17409-Adding timeouts to the requests

* SOAR-17409-Addnf deafult to endpoint
rbowden-r7 added a commit that referenced this pull request Sep 26, 2024
* SOAR-17409-Adding fedramp ready flag to plugin

* SOAR-17409-Adding timeouts to the requests

* SOAR-17409-Addnf deafult to endpoint
rbowden-r7 added a commit that referenced this pull request Oct 7, 2024
* SOAR-17409-Adding fedramp ready flag to plugin

* SOAR-17409-Adding timeouts to the requests

* SOAR-17409-Addnf deafult to endpoint
rmurray-r7 pushed a commit that referenced this pull request Oct 7, 2024
* [Soar 17409] - Microsoft Teams - Adding fedramp true flag (#2805)

* SOAR-17409-Adding fedramp ready flag to plugin

* SOAR-17409-Adding timeouts to the requests

* SOAR-17409-Addnf deafult to endpoint

* SOAR-1709-adding execute permissons to the bin file of teams (#2825)

* SOAR-17409-Bumping SDK to latest (#2830)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants