-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Soar 17409] - Microsoft Teams - Adding fedramp true flag #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablakley-r7
force-pushed
the
develop
branch
from
September 19, 2024 14:18
409b877
to
7e49c36
Compare
rbowden-r7
force-pushed
the
SOAR-17409
branch
from
September 19, 2024 14:19
eac0bd8
to
20a6743
Compare
ekelly-r7
approved these changes
Sep 19, 2024
ablakley-r7
approved these changes
Sep 19, 2024
igorski-r7
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄 Left a small suggestions
plugins/microsoft_teams/icon_microsoft_teams/connection/connection.py
Outdated
Show resolved
Hide resolved
ekelly-r7
pushed a commit
that referenced
this pull request
Sep 24, 2024
* SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint
rbowden-r7
added a commit
that referenced
this pull request
Sep 26, 2024
* SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint
rbowden-r7
added a commit
that referenced
this pull request
Sep 26, 2024
* SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint
rbowden-r7
added a commit
that referenced
this pull request
Oct 7, 2024
* SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint
rmurray-r7
pushed a commit
that referenced
this pull request
Oct 7, 2024
* [Soar 17409] - Microsoft Teams - Adding fedramp true flag (#2805) * SOAR-17409-Adding fedramp ready flag to plugin * SOAR-17409-Adding timeouts to the requests * SOAR-17409-Addnf deafult to endpoint * SOAR-1709-adding execute permissons to the bin file of teams (#2825) * SOAR-17409-Bumping SDK to latest (#2830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Describe the proposed changes:
https://rapid7.atlassian.net/browse/SOAR-17409
PR Requirements
Developers, verify you have completed the following items by checking them off:
Testing
Unit Tests
The unit tests have been updated to now include the resource url
Review our documentation on generating and writing plugin unit tests
In-Product Tests
Testing has been done locally with both actions and triggers and all works as expected
If you are an InsightConnect customer or have access to an InsightConnect instance, the following in-product tests should be done:
Style
Review the style guide
USER nobody
in theDockerfile
when possiblerapid7/insightconnect-python-3-38-slim-plugin:{sdk-version-num}
andrapid7/insightconnect-python-3-38-plugin:{sdk-version-num}
insight-plugin validate
which callsicon_validate
to linthelp.md
Functional Checklist
tests/
directory created withinsight-plugin samples
tests/$action_bad.json
insight-plugin run -T tests/example.json --debug --jq
insight-plugin run -T all --debug --jq
(use PR format at end)insight-plugin run -R tests/example.json --debug --jq
insight-plugin run --debug --jq
(use PR format at end)Assessment
You must validate your work to reviewers:
insight-plugin validate
and make sure everything passesinsight-plugin run -A
. For single action validation:insight-plugin run tests/{file}.json -A
insight-plugin ... | pbcopy
) and paste the output in a new post on this PR