[SOAR-17528] Palo alto Plugin Refresh #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmurray-r7
force-pushed
the
palo_alto_refresh
branch
from
4d6ea2f to
25bd1fc
Compare
rmurray-r7
force-pushed
the
palo_alto_refresh
branch
from
25bd1fc to
15b2e3e
Compare
rmurray-r7
force-pushed
the
palo_alto_refresh
branch
from
97bcd76 to
8aece67
Compare
rmurray-r7
requested review from
cmcnally-r7,
ablakley-r7,
igorski-r7,
dlaverty-r7,
joneill-r7,
ekelly-r7 and
rbowden-r7
igorski-r7
approved these changes
Aug 28, 2024
rbowden-r7
approved these changes
Aug 28, 2024
cmcnally-r7
approved these changes
Aug 28, 2024
igorski-r7
pushed a commit
that referenced
this pull request
Aug 28, 2024
* SDK Bump * Reverting Version * Updating help.md
17 tasks
igorski-r7
pushed a commit
that referenced
this pull request
Aug 29, 2024
* SDK Bump * Reverting Version * Updating help.md
rbowden-r7
pushed a commit
that referenced
this pull request
Sep 3, 2024
* SDK Bump * Reverting Version * Updating help.md
igorski-r7
pushed a commit
that referenced
this pull request
Sep 5, 2024
* SDK Bump * Reverting Version * Updating help.md
rbowden-r7
pushed a commit
that referenced
this pull request
Sep 11, 2024
* SDK Bump * Reverting Version * Updating help.md
rbowden-r7
pushed a commit
that referenced
this pull request
Sep 11, 2024
* SDK Bump * Reverting Version * Updating help.md
rbowden-r7
pushed a commit
that referenced
this pull request
Sep 12, 2024
* SDK Bump * Reverting Version * Updating help.md
rbowden-r7
pushed a commit
that referenced
this pull request
Sep 18, 2024
* SDK Bump * Reverting Version * Updating help.md
ablakley-r7
pushed a commit
that referenced
this pull request
Sep 19, 2024
* SDK Bump * Reverting Version * Updating help.md
ablakley-r7
pushed a commit
that referenced
this pull request
Sep 19, 2024
* SDK Bump * Reverting Version * Updating help.md
ablakley-r7
pushed a commit
that referenced
this pull request
Sep 19, 2024
* SDK Bump * Reverting Version * Updating help.md
cmcnally-r7
pushed a commit
that referenced
this pull request
Sep 23, 2024
* SDK Bump * Reverting Version * Updating help.md
ekelly-r7
pushed a commit
that referenced
this pull request
Sep 24, 2024
* SDK Bump * Reverting Version * Updating help.md
cmcnally-r7
added a commit
that referenced
this pull request
Oct 2, 2024
* Palo Alto Cortex - Get Alerts: Fixed issue where trigger was failing due to empty or wrong typed output fields (#2535) * [SOAR-17528] Palo alto Plugin Refresh (#2740) * SDK Bump * Reverting Version * Updating help.md * [SOAR-17529] Palo alto Cortex XDR Task (#2754) * Logging to find credential headers * test * Fix logging * Spec file refresh * start parse custom config * Successful API Call * Update checksum * Get Alerts * API Call & Custom Config * Some updates * Change limit to 7500 * Return total count * Get timestamp if max limit * Custom testing for pagination * Rough Draft for pagination & switching out get_alerts_two with a better method * Tidy up * Convert alert_time to right format * Convert alert_time to right format * Convert alert_time to right format * Filters * Organise methods & start making request in task.py * Making api call in task.py * Checkpoint * Add headers retrievla in task * It's working * Loads of logging and notes * Ryan checkpoint * Ryan fibannoci murphy * More logging * Setting states * Pagination * Unit test framework * More unit test progress * Task Connection Test * Black . * Some changes and unit testing * Removing a few logger lines/ print statements * Removing monitor_incident_event task * More refactoring * Filter's added + Working * custom config and sort by working * Exception handling improved, still needs minor tweaks * Unit tests * Add url back * Remove lots of comments in task | fix unit test * Some abtracting | refactoring * help.md/plugin.spec updated with SDK bump and examples added. Working through comments * Exception handling working. removed unused constants/lines * changing connection_version, CHECKSUM and reverting changed methods in apy.py to original (change not needed) * Refactoring & making datetime/epoch conversions cleaner and easier * Fix connection SCA * Pagination progress * trying to debug pagination error * Fix SCA in action, refactor request to be in api.py * Remove unused imports * Improve comments * Debugging * Conversion custom_config bug fix * Pagination issue resolved * Drop pagination state * Add len * has_more_pages flag set to false after finished paginating * Tidy a bit * ;-; * Now to fix up the state * Strip Empty Spaces when Inputting API Keys * Tidyed state management * Rename search state variables * Remove testing items and update comments * Fix sca * CHECKSUM FIX * Unit Test Test / Possible workaround? * Unit Test * Change import path for a unit test * Version change and unit test * unit test fixing in progress * strip removed for int * Rename state variables, remove total count from state * Fix pagination again * Woops remove print statement * Comment out unit test * Remove last hash alert from drop state * Change version back to 4.1.0, make connection version 4 * Improving state * Some comments addressed * Remove some repeated logging, add another safety check in api.py * Remove all new unit tests for task * Rename vars, improve logging * Fix pagination again * Streamline datetimes, improve logging * Change version back to 4.0.0 * Fix the spec file * Fixed Task Connection test (updated to new method and params) * Tidy datetime more * Done * Remove authenitcation error in api.py, change post body logging to debug * Datetime fixed * Simplfy task connection test, remove some things in error handling * Fix SCA * Remove logger in connection --------- Co-authored-by: rjmurray <[email protected]> * Update cloud enabled (#2809) * Reset offsets when changing lookback (#2811) * Reset offsets when changing lookback * Reset query endtime back to now * Make it store the int not the datetime object * Pop last search to * Add default none incase of key error * Update pop * Palo Alto | Update error to return error.data (#2823) * Update error to return error.data * Remove print statements * Wrap it in a plugin exception * Palo Alto Cortex XDR - 17008 - Get Alerts: Fixed issue with triggers output validation (#2824) * Rename response to new response * Take headers away from initialisation (#2827) * Palo Alto | Fix start time moving bug, Refactor dedupe logic (#2833) * Add logging for final page, Ensure start & end time are fixed when paginating * Add now time into get alerts * End time and start time static again * Refactor dedupe logic * Remove custom config * Update SDK * Update checksum for task schema --------- Co-authored-by: igorski-r7 <[email protected]> Co-authored-by: rmurray-r7 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Description
Prior to commencing the task implementation; an SDK Bump and Plugin Refresh (and check all integration tests pass) is needed.
This PR will be merged with #2535 which is why there is not a version bump (as the version bump was performed in the other PR)
Describe the proposed changes:
Testing
Tested all the unit tests locally and they pass:
