This repository has been archived by the owner on Oct 27, 2023. It is now read-only.
PD-30979: Upgrade github-connector with a view to containerisation #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e statemachine gem with state-machines as it is no longer maintained. Remove therubyracer gems as no longer required. Replace FactoryGirl with FactoryBot Signed-off-by: aRobinson-R7 <[email protected]>
…ith action method Signed-off-by: aRobinson-R7 <[email protected]>
… gem Signed-off-by: aRobinson-R7 <[email protected]>
…e, can be removed after further testing Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
…us Rails versions to the migration schemas Signed-off-by: aRobinson-R7 <[email protected]>
…ing to access the modified find_for_ldap_authentication method, rather than normalize_ldap_username - calling the parent find_for_ldap_authentication method once normalising the name Signed-off-by: aRobinson-R7 <[email protected]>
…or, which has been replaced with Net::LDAP::Error Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
…rameters as they are. Required for latest version due to method signature change Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
…rking correctly and tests were failing Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
…was added to the deliver_later queue Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
Signed-off-by: aRobinson-R7 <[email protected]>
aRobinson-R7
added
dependencies
…application. Add these files to .gitignore. These can be copied to work with a local run
…compose file for loading the containers in sequence
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to create a containerised environment for testing the github-connector and for possibly deploying it as a container.
It is also to make the following upgrades:
Most changes in this PR are for these upgrades and to make the respective RSpec tests successfully pass.
There is an ongoing issue with the email tests which will require further investigation.
Updated the
app/model/userfile to fix some method aliasing - the tests were expecting to call the addedfind_for_ldap_authenticationmethod, before calling the parent method. They were instead testing the "normalise" method, which returned the normalised username, which should not be the expected functionality in the test.Left in some rendering optional code which can be removed once testing is complete, if it's not needed.