[vnet] Fix IP2ME route creation logic for BITMAP VNET interface (soni…

…c-net#1284) * [vnet] Fix IP2ME route creation logic for BITMAP VNET interface
raphaelt-nvidia · May 21, 2020 · 62d4af4 · 62d4af4
1 parent 2218ed4
commit 62d4af4
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 2 deletions.
diff --git a/orchagent/intfsorch.cpp b/orchagent/intfsorch.cpp
@@ -1052,6 +1052,23 @@ void IntfsOrch::generateInterfaceMap()
     m_updateMapsTimer->start();
 }
 
+bool IntfsOrch::updateSyncdIntfPfx(const string &alias, const IpPrefix &ip_prefix, bool add)
+{
+    if (add && m_syncdIntfses[alias].ip_addresses.count(ip_prefix) == 0)
+    {
+        m_syncdIntfses[alias].ip_addresses.insert(ip_prefix);
+        return true;
+    }
+
+    if (!add && m_syncdIntfses[alias].ip_addresses.count(ip_prefix) > 0)
+    {
+        m_syncdIntfses[alias].ip_addresses.erase(ip_prefix);
+        return true;
+    }
+
+    return false;
+}
+
 void IntfsOrch::doTask(SelectableTimer &timer)
 {
     SWSS_LOG_ENTER();

diff --git a/orchagent/intfsorch.h b/orchagent/intfsorch.h
@@ -60,6 +60,8 @@ class IntfsOrch : public Orch
         return m_syncdIntfses;
     }
 
+    bool updateSyncdIntfPfx(const string &alias, const IpPrefix &ip_prefix, bool add = true);
+
 private:
 
     SelectableTimer* m_updateMapsTimer = nullptr;

diff --git a/orchagent/vnetorch.cpp b/orchagent/vnetorch.cpp
@@ -717,7 +717,7 @@ bool VNetBitmapObject::addIntf(const string& alias, const IpPrefix *prefix)
         intfMap_.emplace(alias, intfInfo);
     }
 
-    if (prefix)
+    if (prefix && gIntfsOrch->updateSyncdIntfPfx(alias, *prefix))
     {
         gIntfsOrch->addIp2MeRoute(gVirtualRouterId, *prefix);
     }
@@ -739,7 +739,7 @@ bool VNetBitmapObject::removeIntf(const string& alias, const IpPrefix *prefix)
 
     auto& intf = intfMap_.at(alias);
 
-    if (prefix)
+    if (prefix && gIntfsOrch->updateSyncdIntfPfx(alias, *prefix, false))
     {
         gIntfsOrch->removeIp2MeRoute(gVirtualRouterId, *prefix);
     }