Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit mkPolyline from tvOS 8, watchOS builds #40

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Feb 19, 2017

Fixed the following compilation errors on tvOS and watchOS introduced by #39:

/path/to/Polyline/Polyline/Polyline.swift
/path/to/Polyline/Polyline/Polyline.swift:59:28: 'MKPolyline' is only available on tvOS 9.2 or newer
/path/to/Polyline/Polyline/Polyline.swift:59:28: Add @available attribute to enclosing var
/path/to/Polyline/Polyline/Polyline.swift:59:28: Add @available attribute to enclosing struct
/path/to/Polyline/Polyline/Polyline.swift:61:26: 'MKPolyline' is only available on tvOS 9.2 or newer
/path/to/Polyline/Polyline/Polyline.swift:61:26: Add 'if #available' version check
/path/to/Polyline/Polyline/Polyline.swift:61:26: Add @available attribute to enclosing var
/path/to/Polyline/Polyline/Polyline.swift:61:26: Add @available attribute to enclosing struct
/path/to/Polyline/Polyline/Polyline.swift
/path/to/Polyline/Polyline/Polyline.swift:59:28: Use of undeclared type 'MKPolyline'
/path/to/Polyline/Polyline/Polyline.swift:61:26: Use of unresolved identifier 'MKPolyline'
/path/to/Polyline/Polyline/Polyline.swift:59:16: Did you mean 'mkPolyline'?
/path/to/Polyline/Polyline/Polyline.swift:41:15: Did you mean 'Polyline'?

/cc @tomtaylor @frederoni

Fixed compilation errors on tvOS and watchOS.
@1ec5 1ec5 changed the title Omit mkPolyline from tvOS, watchOS builds Omit mkPolyline from tvOS 8, watchOS builds Feb 19, 2017
@1ec5
Copy link
Collaborator Author

1ec5 commented Mar 8, 2017

@tomtaylor @raphaelmor, can you take a look? (For what it’s worth, I’d be happy to help out as a collaborator, since I maintain some libraries that depend on this library.)

@raphaelmor
Copy link
Owner

I'm adding you as a collaborator, if @tomtaylor is fine with, the more the merrier (and I can't contribute anymore :( )

@tomtaylor
Copy link
Collaborator

tomtaylor commented Mar 9, 2017 via email

@1ec5 1ec5 merged commit c54b1d3 into raphaelmor:master Mar 9, 2017
@1ec5 1ec5 deleted the 1ec5-mapkit-tvos branch March 9, 2017 16:53
@1ec5
Copy link
Collaborator Author

1ec5 commented Mar 9, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants