Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle missing qnodes or qedges #13

Merged
merged 2 commits into from
Jun 8, 2020
Merged

handle missing qnodes or qedges #13

merged 2 commits into from
Jun 8, 2020

Conversation

patrickkwang
Copy link
Contributor

Fixes #3.

@patrickkwang patrickkwang requested a review from maximusunc June 8, 2020 20:10
@patrickkwang
Copy link
Contributor Author

Also fixes #5.

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          303       310    +7     
=========================================
+ Hits           303       310    +7     
Impacted Files Coverage Δ
reasoner/cypher.py 100.00% <100.00%> (ø)
reasoner/nesting.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea0a1f...7dbe861. Read the comment docs.

@maximusunc
Copy link
Collaborator

Something to discuss: if the user passes in a qgraph that is missing nodes or edges, we aren't catching that and the application will error when trying to mapize the qgraph. Do we want some sort of check to make sure those properties are there? The error thrown is a KeyError.

@maximusunc
Copy link
Collaborator

👍

@patrickkwang patrickkwang requested a review from maximusunc June 8, 2020 20:35
@patrickkwang patrickkwang merged commit b0dc3aa into master Jun 8, 2020
@patrickkwang patrickkwang deleted the empty-qgraph branch June 17, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query generation doesn't handle a qgraph with no edges.
2 participants