fix: fix tx data for evm signers when transfering native tokens

rango-exchange · Jun 24, 2024 · a5d9f6e · a5d9f6e
1 parent 4ed178d
commit a5d9f6e
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/signers/signer-evm/src/signer.ts b/signers/signer-evm/src/signer.ts
@@ -63,15 +63,19 @@ export class DefaultEvmSigner implements GenericSigner<EvmTransaction> {
   static buildTx(evmTx: EvmTransaction, disableV2 = false): TransactionRequest {
     const TO_STRING_BASE = 16;
     let tx: TransactionRequest = {};
+    /*
+     * it's better to pass 0x instead of undefined, otherwise some wallets could face issue
+     * https://github.com/WalletConnect/web3modal/issues/1082#issuecomment-1637793242
+     */
+    tx = {
+      data: evmTx.data || '0x',
+    };
     if (evmTx.from) {
       tx = { ...tx, from: evmTx.from };
     }
     if (evmTx.to) {
       tx = { ...tx, to: evmTx.to };
     }
-    if (evmTx.data) {
-      tx = { ...tx, data: evmTx.data };
-    }
     if (evmTx.value) {
       tx = { ...tx, value: evmTx.value };
     }