Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Meson build with configuration #135

Closed
wants to merge 6 commits into from

Conversation

concatime
Copy link
Contributor

Plus some minor changes.

Would you like to add a .clang-format in the repo? Something simple, like

AllowShortIfStatementsOnASingleLine: true
BasedOnStyle: Microsoft
ColumnLimit: 80

@randy408
Copy link
Owner

The SPNG_STATIC define is the only macro that is sometimes required before including spng.h, even that is only needed on Windows, the rest are compile-time options and have no effect inside a config.h. When the Meson or CMake project is used it's defined automatically, I don't think it makes sense to have it in a header, especially if the library has both static and dynamic builds.

With that in mind, I'm against a config.h and moving spng.h into a separate directory.

I haven't considered a .clang-format, there aren't that many contributors.

@concatime
Copy link
Contributor Author

concatime commented Nov 28, 2020

Understood. Give me some time and I will rework my patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants