Use a better approach for modular subtraction #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For pcurves this improves overall ECDH/ECDSA performance from anywhere from 5% to up to 15% (!) depending on the curve. Remove the templatized length variant of bigint_mod_sub; this only existed as a performance hack for EC_Point and is much less relevant with pcurves in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pcurves this improves overall ECDH/ECDSA performance from anywhere from 5% to up to 15% (!) depending on the curve.
Remove the templatized length variant of bigint_mod_sub; this only existed as a performance hack for EC_Point and is much less relevant with pcurves in use.
#4027