Refactor public key related performance test code #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/refactor-speed-pk
branch
from
8b6f333 to
fc2d731
Compare
Also remove the pcurves ECDH/ECDSA benchmarks which are not relevant anymore, now that EC_Group/EC_Scalar/EC_AffinePoint use pcurves internally.
This is apparently necessary for MSVC to export it
reneme
reviewed
Oct 14, 2024
Comment on lines
+94
to
+99
| "Kyber-512-r3", | ||
| "Kyber-512-90s-r3", | ||
| "Kyber-768-r3", | ||
| "Kyber-768-90s-r3", | ||
| "Kyber-1024-r3", | ||
| "Kyber-1024-90s-r3", |
There was a problem hiding this comment.
Admittedly, a bit late to the party. Nevertheless: When building with --disable-modules=kyber_90s, this will error with:
Kyber-Kyber-512-r3 65559 KEM encrypt/sec; 0.02 ms/op 38070 cycles/op (26176 ops in 399 ms)
Kyber-Kyber-512-r3 52351 KEM decrypt/sec; 0.02 ms/op 47679 cycles/op (26176 ops in 500 ms)
Error: Not implemented requested Kyber mode is not enabled in this build
... instead of skipping the Kyber 90s modes. Similarly for other algorithms where specific groups of modes may be disabled at build time.
Could be fixed by (for instance):
#if defined(BOTAN_HAS_KYBER)
"Kyber-512-r3",
"Kyber-768-r3",
"Kyber-1024-r3",
#endif
#if defined(BOTAN_AS_KYBER_90S)
"Kyber-512-90s-r3",
"Kyber-768-90s-r3",
"Kyber-1024-90s-r3",
#endif
This was referenced Oct 14, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.