Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use array-based load_be/le in MD hashes #4244

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Jul 22, 2024

Using the load_le/load_be overloads with statically sized ranges results in less code (and also less runtime checks) (not compared to the raw-ptr overloads). ... please excuse my indentation OCD. 😏

Quick measurement doesn't show any accidents (in MiB/s).

master Chore/mdx_revamp
MD4 545.190 547.178
MD5 305.430 304.652
SHA-1 341.379 339.967
SHA-256 180.383 180.365
SHA-512 277.988 278.101
RIPEMD-160 270.644 270.539
SM3 163.148 163.073

@reneme reneme requested a review from randombit July 22, 2024 14:16
@reneme reneme self-assigned this Jul 22, 2024
@coveralls
Copy link

coveralls commented Jul 22, 2024

Coverage Status

coverage: 91.663% (-0.009%) from 91.672%
when pulling b793376 on Rohde-Schwarz:chore/mdx_revamp
into a66e252 on randombit:master.

@reneme reneme force-pushed the chore/mdx_revamp branch from bb653e9 to b793376 Compare July 23, 2024 06:14
@reneme reneme merged commit e1fc592 into randombit:master Jul 24, 2024
39 checks passed
@reneme reneme deleted the chore/mdx_revamp branch July 24, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants