Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::lcm in Cascade_Cipher #4150

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Use std::lcm in Cascade_Cipher #4150

merged 1 commit into from
Jun 26, 2024

Conversation

randombit
Copy link
Owner

No description provided.

@randombit randombit requested a review from reneme June 26, 2024 10:41
reneme
reneme approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is std::lcm and it is constexpr and it was available in C++17 already?

🤯

@coveralls
Copy link

Coverage Status

coverage: 91.715% (-0.006%) from 91.721%
when pulling e61f9d9 on jack/use-lcm
into e914169 on master.

@randombit
Copy link
Owner Author

I think this is the first time I've scooped you on a C++ feature rather than the reverse 😂

@randombit randombit merged commit 66216e1 into master Jun 26, 2024
42 checks passed
@randombit randombit deleted the jack/use-lcm branch June 26, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randombit @coveralls @reneme