Attempt to fix use-after-free in tls_proxy CLI test #4148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the TLS session to the client was established (when tls_session_activated() was called), and the connection to the server was also established successfully (ec in onConnect() callback was not set); but -- in the mean time -- the this- pointer was deallocated via std::enable_shared_from_this, we end up in a use- after free situation. This sporadically apeeared in CI but wasn't reproducible locally, see randombit#4112.
reneme
force-pushed
the
fix/tls_proxy_asan
branch
from
47f00c4 to
6baec20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an attempt to reproduce on CI... I re-enabled the test on windows in the hope to increase the failure cross-section.