Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fixed block size implementations of XEX encryption #4145

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Remove fixed block size implementations of XEX encryption #4145

merged 1 commit into from
Jun 24, 2024

Conversation

randombit
Copy link
Owner

Somewhat inexplicably this saves 120 KB in the final shared object

@randombit
Remove fixed block size implementations of XEX encryption
5f1c07c 
Somewhat inexplicably this saves 120 KB in the final shared object
@coveralls
Copy link

Coverage Status

coverage: 91.74% (+0.002%) from 91.738%
when pulling 5f1c07c on jack/virt-xex
into d24c2c3 on master.

@randombit randombit added this to the Botan 3.5.0 milestone Jun 22, 2024
reneme
reneme approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat inexplicably this saves 120 KB in the final shared object

Even though it is not used anywhere? Curious!

@randombit randombit merged commit 747aa2b into master Jun 24, 2024
42 checks passed
@randombit randombit deleted the jack/virt-xex branch June 24, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneme reneme reneme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Botan 3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@randombit @coveralls @reneme