Refactor AlternativeName internals #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
force-pushed
the
jack/refactor-alt-name
branch
2 times, most recently
from
76749a9 to
eaf35a1
Compare
randombit
force-pushed
the
jack/refactor-alt-name
branch
3 times, most recently
from
7569eb6 to
ab85979
Compare
FAlbertDev
approved these changes
Apr 30, 2024
randombit
force-pushed
the
jack/refactor-alt-name
branch
from
20775f2 to
c0eda69
Compare
This provides a completely new and rather more sensible interface, with the old (now deprecated) interface being implemented in terms of the new interface. It also resolves a performance issue when parsing certificates with many (thousands) of alternative names; previously this triggered some accidentally quadratic code when checking for duplicates. Performance issue was reported by Bing Shi.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a completely new and rather more sensible interface, with the old (now deprecated) interface being implemented in terms of the new interface.
It also resolves a performance issue when parsing certificates with many (thousands) of alternative names; previously this triggered some accidentally quadratic code when checking for duplicates.
Performance issue was reported by Bing Shi.