Add word3 type and take advantage of Clang's _BitInt extension #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated code is surprisingly good
randombit
force-pushed
the
jack/word3-type
branch
from
f594fb5 to
54009f0
Compare
|
@reneme Don't know if you want to review this one or not. Diff is huge but it's 99% generated code |
reneme
approved these changes
Apr 9, 2024
Merge the declaration of the type in the two preprocessor blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang generates much better code with
_BitIntthan otherwise. This improves performance with Clang by ~5% for ECDSA/ECDH and 10-20% improvement for FFDHE depending on sizes. Unfortunately until Clang 16 the maximum_BitIntsize was 128 bits, so it is only useful with newer Clang.