Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't stop the ninja build if errors occur #3952

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

randombit
Copy link
Owner

This mirrors the behavior used for make

This mirrors the behavior used for make
@coveralls
Copy link

Coverage Status

coverage: 92.082% (+0.001%) from 92.081%
when pulling 13504a7 on jack/ninja-keep-going
into 3a07586 on master.

Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

... we should also look into parsing the compiler errors and rendering them into the pull request diff. Hopefully, that would avoid quite a bit of log scrolling. It's on my list for a long time. 😅

@randombit randombit merged commit 626dc64 into master Mar 28, 2024
43 checks passed
@randombit randombit deleted the jack/ninja-keep-going branch March 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants