Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds for compilers that didn't implement C++20 concepts #3908

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

randombit
Copy link
Owner

No description provided.

@randombit randombit requested a review from reneme February 16, 2024 11:36
@randombit randombit force-pushed the jack/use-std-concepts branch from 6e427cd to 7d8ccb7 Compare February 16, 2024 11:50
Copy link
Collaborator

@reneme reneme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh! I've been procrastinating on that. Now you've beat me to it. Thanks!

@coveralls
Copy link

Coverage Status

coverage: 92.006%. remained the same
when pulling 7d8ccb7 on jack/use-std-concepts
into d0b2107 on master.

@randombit
Copy link
Owner Author

LOL no worries I'm the one who's behind right now!

I was just reminded of this on reading #3890 and remembered at this point (given our NDK/XCode min requirements) we probably could remove some of these hacks.

@randombit randombit merged commit 13c7e5f into master Feb 16, 2024
39 checks passed
@randombit randombit deleted the jack/use-std-concepts branch February 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants