Refactor: Kyber internals #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
force-pushed
the
refactor/kyber
branch
from
a5d3284 to
2356f56
Compare
|
Force-pushed after #3888, to fix CI. |
FAlbertDev
approved these changes
Jan 17, 2024
reneme
force-pushed
the
refactor/kyber
branch
3 times, most recently
from
95143b8 to
3fc1233
Compare
This was referenced Jan 18, 2024
Merged
FAlbertDev
approved these changes
Jan 19, 2024
FAlbertDev
force-pushed
the
refactor/kyber
branch
from
56b1741 to
c5a5396
Compare
reneme
force-pushed
the
refactor/kyber
branch
from
c5a5396 to
dc661f6
Compare
reneme
force-pushed
the
refactor/kyber
branch
from
dc661f6 to
d523931
Compare
|
Rebased and resolved conflicts after #3874 got merged. |
|
Thanks for the review! We have a further iteration for this in the pipeline, though. It'll be a few weeks before we're done with it, unfortunately. Currently busy preparing the concluding workshop for BSI's project 481. |
|
Resolved a conflict with master. |
* BufferStuff/Slicer * Strong types * Prepare for introduction of ML-KEM (ipd) * introduce nomenclature of FIPS 203
|
I realized that the planned changes, I mentioned last month, can be easily added on top of this. So, let's merge this now and we'll continue working on master. |
reneme
added a commit
to sehlen-bsi/botan-docs
that referenced
this pull request
Jul 2, 2024
See: randombit/botan#3887 This is a fairly minimal adaption, once the full refactoring is merged, we'll have to rewrite this more substantially. That won't happen before Botan 3.5.0, though. See also: randombit/botan#4024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an iteration of the Kyber internals, in preparation of an ML-KEM implementation. Also, it retrofits the helpers we added along the way in the last two years. Most notably:
BufferStufferandBufferSlicerandStrong<>types. Especially the strong types made it possible to restrict the "symmetric algorithms" inkyber_symmetric_primitives.h.Before, most of the algorithm (i.e. the Polynomial structures) was hidden away in the
kyber.cppcompilation unit in thekyber_commonmodule. For added flexibility, I restructured the code into a few distinct header and implementation files. Also, thekyberandkyber_90smodules now moved inside a new internalkyber_round3module. These changes make room for an upcoming ML-KEM-ipd implementation that reuses as much of the implementation as possible.The public interface isn't affected by any of those changes.